feat(python): Support the most recent version of "duckdb_engine" connections via read_database
#18277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ections via `read_database`
alexander-beedie
requested review from
ritchie46,
c-peters,
MarcoGorelli and
reswqa
as code owners
github-actions
bot
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18277 +/- ##
==========================================
- Coverage 80.21% 80.21% -0.01%
==========================================
Files 1500 1500
Lines 198897 198897
Branches 2837 2837
==========================================
- Hits 159547 159540 -7
- Misses 38822 38829 +7
Partials 528 528 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18263.
One of those rare two-character fixes... ;)
Following the "duckdb_engine" code a little more closely showed that we didn't need to expose the inner/private connection object to take advantage of the
fetch_arrow_tablefast path; the driver connection's__getattr__accesses it implicitly for us. (Explicit access via.cwas deprecated and removed recently, hence the reported error).Confirmed the fix works and still takes the Arrow-aware fast path with old/new versions of the "duckdb_engine" alchemy driver.